[PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

Stephen Rothwell sfr at canb.auug.org.au
Thu Oct 18 15:22:54 EST 2007


On Wed, 17 Oct 2007 18:04:49 -0500 linas at austin.ibm.com (Linas Vepstas) wrote:
>
> Is this really useful or wise?

Yes, it is.  We are *replacing* an interface that does no ref counting
with one that does.

> As a matter of personal taste, I find stuff like this clutters

What has taste got to do with it?  And as for cluttering, you can page
out the previous interface and page in the new one.  :-)

> I don't much like this style, and I've been known to submit
> patches that remove stuff like this ... 

What "style" are you referring to?

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20071018/c497f5b1/attachment.pgp>


More information about the Linuxppc-dev mailing list