[PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

David Miller davem at davemloft.net
Wed Oct 17 21:23:45 EST 2007


From: David Miller <davem at davemloft.net>
Date: Wed, 17 Oct 2007 04:22:29 -0700 (PDT)

> From: Michael Ellerman <michael at ellerman.id.au>
> Date: Wed, 17 Oct 2007 17:12:27 +1000 (EST)
> 
> > Use of_get_pci_dev_node() in axon_msi.c. Switch to including <linux/of.h>
> > so we get the prototype.
> > 
> > Signed-off-by: Michael Ellerman <michael at ellerman.id.au>
> 
> I find it ironic that you add of_get_pci_dev_node() as a function
> which gets the node and grabs a reference to it, and then the very
> first usage you make of it doesn't drop the reference at all.

Ignore this poor attempt at humor, I misread your patch :)



More information about the Linuxppc-dev mailing list