[PATCH v2] Device tree bindings for Xilinx devices

Stephen Neuendorffer stephen.neuendorffer at xilinx.com
Wed Oct 17 04:24:07 EST 2007


> +   n) Xilinx EMAC and Xilinx TEMAC
> +
> +   Xilinx Ethernet devices.  Uses common properties from 
> other Ethernet
> +   devices with the following constraints:
> +   
> +   Required properties:
> +    - compatible : Must include one of: "xilinx,plb-temac",
> +                   "xilinx,plb-emac", "xilinx-opb-emac"
> +    - dma-mode : Must be one of "none", "simple", "sg" (sg 
> == scatter gather)

I think it's going to be a significant headache to remap things like the
dma-mode from the xilinx configurations to something else, and then
interpret them correctly in the drivers.

Although it lacks a bit in style, perhaps, I'd greatly prefer having
something like:

	Ethernet_MAC {
		xilinx,C_DMA_PRESENT = <1>;
            ...
      }

(which happens to correspond to "none" above)
DMA mode is perhaps a bad example, since the Xilinx EDK encoding for
this is so unnecessarily obfuscated, but I'd like to avoid setting
precedent for defining a new set of parameterizations here.  In the long
term, I'm afraid this will just be an added source of confusion and more
code to maintain.

Steve




More information about the Linuxppc-dev mailing list