mpc52xx bestcomm patches.

[Kumar Gala]

On Oct 12, 2007, at 1:30 PM, Grant Likely wrote:

> Paulus, how do you feel about merging these changes?
>
> This is Sylvain's series of bestcomm patches.
>
> http://patchwork.ozlabs.org/linuxppc/patch?id=13488
> http://patchwork.ozlabs.org/linuxppc/patch?id=13489
> http://patchwork.ozlabs.org/linuxppc/patch?id=13490
> http://patchwork.ozlabs.org/linuxppc/patch?id=13491
> http://patchwork.ozlabs.org/linuxppc/patch?id=13492
> http://patchwork.ozlabs.org/linuxppc/patch?id=13493
> http://patchwork.ozlabs.org/linuxppc/patch?id=13494
>
> There are still a few minor issues to be resolved, but Sylvain is
> suffering from a severe lack of time and this series has been stalled
> for a long time because of it.  Domen and others have been working on
> drivers which use bestcomm, but they can neither get their drivers
> included nor address the issues in this series because of it.
>
> Personally, I think it will be better to just merge it now and allow
> others to address the remaining comments.  It's not like this is a
> change to an old device that could be risky.

I'm against this getting merged w/o addressing some of the long  
standing comments I've made:

http://ozlabs.org/pipermail/linuxppc-dev/2007-May/036224.html
http://ozlabs.org/pipermail/linuxppc-dev/2007-September/042632.html
http://ozlabs.org/pipermail/linuxppc-dev/2007-September/042633.html

Additionally I think ALL new "libraries" like this should come with  
kerneldoc.

- k