[PATCH v2] powerpc: don't enable cpu hotplug on mpic-based pseries

Milton Miller miltonm at bga.com
Fri Oct 12 07:42:51 EST 2007


Paul Mackerras writes:
> Olof Johansson writes:
>> Don't allow cpu hotplug on systems lacking XICS interrupt controller,
>> since current code is hardcoded for it.
> ...
>> +	for (np = NULL; (np = of_find_node_by_name(np,
>> +						   "interrupt-controller"));) {
> 
> Looks like for_each_node_by_name would be nicer here.
> 
> If you agree, I'll hand-edit your patch to do that and apply it.  Of
> course, ultimately we should implement the necessary mpic bits to
> support cpu hotplug.
> 

While you are editing, can you please change the condition to finding
ppc-xicp instead of not finding open-pic?

thanks.
milton




More information about the Linuxppc-dev mailing list