[PATCH] qe: add function qe_clock_source

Kumar Gala galak at kernel.crashing.org
Wed Oct 10 05:50:01 EST 2007


On Oct 9, 2007, at 2:18 PM, Timur Tabi wrote:

> Kumar Gala wrote:
>
>> Ok.  I guess I'm not in favor of changing the device tree to  
>> address this issue.  I think it would be solved if "dtc" had  
>> #define support.
>
> Not really.  The #defines would then need to match the enum, and  
> that's dual maintenance.  This method is better because you can use  
> the real name of the clock source in the DTS.  That keeps the DTS  
> from having to know the internal representation of clock sources.
>
> (BTW, when I said "I just understand", I meant "I just don't  
> understand".)

I misread the idea.  I'm ok with using a string, just use a new prop  
name and deprecate the old names in booting-without-of.txt

Also, I think Scott suggested this but I'd say parse the string for  
"BRG" & "CLK" and the decimal number and use some enum + math rather  
than a big lookup table.

- k



More information about the Linuxppc-dev mailing list