[PATCH] qe: add function qe_clock_source

Kumar Gala galak at kernel.crashing.org
Wed Oct 10 04:10:53 EST 2007


On Oct 9, 2007, at 11:48 AM, Timur Tabi wrote:

> Scott Wood wrote:
>
>> In the absence of a BRG, the driver should just not support  
>> changing the baud rate -- it shouldn't fail to function.
>
> Since I don't have hardware that can test external clocks, I can't  
> guarantee that any such code will work.
>
> I'm sure there are a dozen things I could do to improve the driver  
> as it stands, but I need to draw the line somewhere.

I guess my point is it appears the patch is related to how we  
represent the RX/TX clock information in the device tree.

I'm suggesting that we do something like:

rx-clock-type = "brg" or "clk"
rx-clock-id = 3

I don't see how this doesn't cover what you need in the device tree.

- k



More information about the Linuxppc-dev mailing list