[POWERPC 03/15] [POWERPC] TQM5200 board support

Stephen Rothwell sfr at canb.auug.org.au
Sun Oct 7 22:21:19 EST 2007


On Sun, 07 Oct 2007 13:19:54 +0200 Marian Balakowicz <m8 at semihalf.com> wrote:
>
> +++ b/arch/powerpc/platforms/52xx/tqm5200.c
>
> +#include <asm/prom.h>

You need this for the flattened device tree stuff, so good. However ...

> +#include <asm/of_platform.h>

You should not include this file.  And you actually don't use any of the
of_platform routines, but you do need linux/of.h for the of_find_ ...
routines.

> +void tqm5200_show_cpuinfo(struct seq_file *m)
> +{
> +	struct device_node* np = of_find_all_nodes(NULL);

Not sure about this - if you want to find the root node, then you should
probably do that explicitly.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20071007/d5f74a98/attachment.pgp>


More information about the Linuxppc-dev mailing list