[PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels

Josh Boyer jwboyer at linux.vnet.ibm.com
Fri Oct 5 00:42:17 EST 2007


On Fri, 05 Oct 2007 00:34:45 +1000
Michael Ellerman <michael at ellerman.id.au> wrote:

> On Thu, 2007-10-04 at 05:56 -0500, Josh Boyer wrote:
> > On Wed, 2007-10-03 at 22:50 -0600, Grant Likely wrote:
> > > From: Grant Likely <grant.likely at secretlab.ca>
> > > 
> > > dcr.c is an arch/powerpc only thing.
> > > 
> > > Signed-off-by: Grant Likely <grant.likely at secretlab.ca>
> > > ---
> > > 
> > > Ben/Paulus,
> > > 
> > > As far as I can tell this is correct.  Having sysdev/dcr.c in the arch/ppc
> > > build spits out warnings.  Grep doesn't show anything in arch/ppc that
> > > is using it.
> > 
> > Sorry, no.  The ibm_emac driver uses it, which is arch/ppc.  (Yes, the
> > old one.)
> > 
> > If there are warnings, let's fix those up.  Perhaps Michael's recent
> > patches in that area introduced something.
> 
> Hmm, I picked a good time to be away :)
> 
> I think it's OK. ibm_emac uses dcr_write() but it should always be using
> the native one from dcr-native.h. So I think this patch is good.

Agreed.

> Just another reason to get rid of arch/ppc :D

Agreed.

josh



More information about the Linuxppc-dev mailing list