[PATCH] Don't build arch/powerpc/sysdev/dcr.c for ARCH=ppc kernels

Josh Boyer jwboyer at linux.vnet.ibm.com
Thu Oct 4 22:16:54 EST 2007


On Thu, 04 Oct 2007 21:08:04 +1000
Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:

> 
> On Thu, 2007-10-04 at 05:56 -0500, Josh Boyer wrote:
> > On Wed, 2007-10-03 at 22:50 -0600, Grant Likely wrote:
> > > From: Grant Likely <grant.likely at secretlab.ca>
> > > 
> > > dcr.c is an arch/powerpc only thing.
> > > 
> > > Signed-off-by: Grant Likely <grant.likely at secretlab.ca>
> > > ---
> > > 
> > > Ben/Paulus,
> > > 
> > > As far as I can tell this is correct.  Having sysdev/dcr.c in the arch/ppc
> > > build spits out warnings.  Grep doesn't show anything in arch/ppc that
> > > is using it.
> > 
> > Sorry, no.  The ibm_emac driver uses it, which is arch/ppc.  (Yes, the
> > old one.)
> > 
> > If there are warnings, let's fix those up.  Perhaps Michael's recent
> > patches in that area introduced something.
> 
> What does it use of dcr.c ? Initially, the 4xx bits where totally
> inline, but maybe Michael's patches is changing that ?

Gah.  Sorry, I was thinking of dcr-low.S, not dcr.c.  And poor Michael
has nothing to do with it.

Drink coffee.  Then think.

josh



More information about the Linuxppc-dev mailing list