[PATCH] fsl_spi_init: Support non-QE processors
Kumar Gala
galak at kernel.crashing.org
Thu Oct 4 08:11:05 EST 2007
On Oct 3, 2007, at 1:17 PM, Grant Likely wrote:
> On 10/3/07, Peter Korsgaard <jacmet at sunsite.dk> wrote:
>>>>>>> "Grant" == Grant Likely <grant.likely at secretlab.ca> writes:
>>
>> Hi,
>>
>> Grant> Why not just:
>>
>> Grant> np = of_find_node_by_type(NULL, "qe");
>> Grant> + if (!np)
>> Grant> + np = of_find_node_by_type(NULL, "soc");
>> Grant> if (!np)
>> Grant> return -ENODEV;
>>
>> My first iteration did it like that, but then you don't get a -ENODEV
>> if the node is missing (and you'll end up using the wrong clock) and
>> it doesn't support processors with SPI on and off QE (if that
>> exists/will ever exist).
>
> Okay, but you should at least be able confine your determination of
> which sysclk value to use to one part of the function. Otherwise, it
> looks good.
Peter, can you respin this w/Grant's modification. I've grabbed the
other patches and applied them. waiting on this one.
- k
More information about the Linuxppc-dev
mailing list