[PATCH] Add MPC837xEMDS PCIE RC mode support

Olof Johansson olof at lixom.net
Fri Nov 30 15:14:04 EST 2007


Hi,

On Fri, Nov 30, 2007 at 11:45:34AM +0800, Li Li wrote:

> +	pci2 at e0009000 {

Why call it pci2@ (and pci3@ below)? They are clearly identifiable with 
their unit addresses anyway.

> +config PPC_MPC83XX_PCIE
> +	bool "MPC837X PCI Express support"
> +	depends on PCIEPORTBUS && PPC_MPC837x
> +	default n
> +	help
> +	  Enables MPC837x PCI express RC mode

Why have a separate config option for this?

For systems where you don't want PCI-e configured, it should be left
out of the device tree instead.



-Olof



More information about the Linuxppc-dev mailing list