[PATCH] PPC: CELLEB - fix potential NULL pointer dereference

Ishizaki Kou kou.ishizaki at toshiba.co.jp
Wed Nov 28 19:52:38 EST 2007


> This patch adds checking for NULL value returned to prevent possible
> NULL pointer dereference.
> Also two unneeded 'return' are removed.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>

Thanks, I tested your patch and it works.

My original code supposes that the device-tree is provided correctly,
so I omited such checks. (Sorry, it should have been commented.)

Should we check more strictly like your patch?

Best regards,
Kou Ishizaki



More information about the Linuxppc-dev mailing list