[PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

Stephen Rothwell sfr at canb.auug.org.au
Wed Nov 28 11:41:04 EST 2007


On Tue, 27 Nov 2007 18:39:08 +0300 Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
>
> +static int __devinit pata_of_platform_probe(struct of_device *ofdev,
> +					    const struct of_device_id *match)
> +{
> +	uint32_t *prop;

Make this "const uint32_t *prop" or (more kernel like) "const u32 *prop" ...

> +	prop = (uint32_t *)of_get_property(dn, "ioport-shift", NULL);

then you don't need this cast.  Anytime you use a cast to get rid of
"const", is probably a mistake.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20071128/362436ab/attachment.pgp>


More information about the Linuxppc-dev mailing list