[PATCH] e1000: Fix for 32 bits platforms with 64 bits resources
auke-jan.h.kok at intel.com
Tue Nov 27 10:15:12 EST 2007
Jeff Garzik wrote:
> Benjamin Herrenschmidt wrote:
>> The e1000 driver stores the content of the PCI resources into
>> unsigned long's before ioremapping. This breaks on 32 bits
>> platforms that support 64 bits MMIO resources such as ppc 44x.
>> This fixes it by removing those temporary variables and passing
>> directly the result of pci_resource_start/len to ioremap.
>> The side effect is that I removed the assignments to the netdev
>> fields mem_start, mem_end and base_addr, which are totally useless
>> for PCI devices.
>> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
>> drivers/net/e1000/e1000_main.c | 18 +++++-------------
>> 1 file changed, 5 insertions(+), 13 deletions(-)
> Looks good to me. auke?
yes, please apply.
Acked-by: Auke Kok <auke-jan.h.kok at intel.com>
More information about the Linuxppc-dev