dtc: Remove some redundant testcases

Jon Loeliger jdl at jdl.com
Tue Nov 27 08:21:10 EST 2007


So, like, the other day David Gibson mumbled:
> This patch removes a number of testcases from the testsuite that are
> extremely unlikely to find any bugs that won't be found by the other
> tests.  This speeds up the testsuite.
> 
> 	- Both loops across the various tree block layouts run the
> tree1_tests on the basic mangled tree.  This is completely redundant,
> so remove the second copy. This removes 456 testcases.
> 
> 	- We currently run tree1_tests on various trees manipulated by
> move_and_save.  We replace those with just a dtbs_equal_ordered test
> to check that the manipulated tree is equal to the original.  What
> we're testing here is that fdt_move() operates correctly - it's very
> unlikely it would succeed well enough for the ordered_equal test to
> succeed, but the tree1_tests would fail on the result.  This removes
> 162 testcases.
> 
> 	- Currently we re-ordered with mangle-layout both the basic
> test_tree1.dtb and sw_tree1.test.dtb.  Since we've already checked
> that these dtbs are equivalent with dtbs_ordered_equal, it's very
> unlikely that the tests would fail on one but not the other.
> Therefore reduce this to only using test_tree1.dtb.  This removes 828
> testcases.


Applied.

Thanks,
jdl



More information about the Linuxppc-dev mailing list