[RFC/PATCHv3] powerpc: Move CPM command handling into the cpm drivers

Jochen Friedrich jochen at scram.de
Tue Nov 27 03:56:30 EST 2007

Hi Scott,

>> +    spin_lock_irqsave(&cmd_lock, flags);
> I'm a little uneasy about this -- what's the longest it can take for the
> CPM command to complete (or timeout)?  I'd rather use a mutex, if we can
> make sure that it's never called from atomic context.

Unfortunately, fs_enet may call this from interrupt context.

>> +EXPORT_SYMBOL_GPL(cpm_command);
> Can we please not play the GPL DRM game here?

Arnd Bergmann proposed to change that, but you're right. This really is part
of the CPM API, so i'll revert this.


More information about the Linuxppc-dev mailing list