[RFC][PATCH 0/3] OF-platform PATA driver

Vitaly Bordug vitb at kernel.crashing.org
Sat Nov 24 13:35:32 EST 2007

On Fri, 23 Nov 2007 20:52:29 +0300
Anton Vorontsov wrote:

> Hi all,
> Here is the PATA Platform driver using OF infrastructure.
> Mostly it's just a wrapper around a bit modified pata_platform
> driver.
> Patches are well split for the easier review:
> First one factors out platform_device specific bits and modifies
> pata_platform to be a library-alike driver (with platform_device
> default binding).
> Second patch is OF-driver itself which is using pata_platform
> "library".
> Third patch is PowerPC specific, but I'm still Cc'ing linux-ide,
> just to show how we're using it.
> As an alternative approach we can use plain pata_platform
> driver, but I'm not sure how Linux OF bindings' ideologists will
> or will not like it.
> So, these patches are strongly Request For Comments. Feel free
> to train your nitpicking skills ;-), and/or vote for the option
> you most pleased about (or suggest another?).

I vote for of_platform_device, since we seem to dodge the clash
with platform_device here.

The code looks good, so I'm going to ack all 3 patches and if there will
be no more nagging, I'm inclined to ask Kumar to queue this for the next merge window.

Sincerely, Vitaly

More information about the Linuxppc-dev mailing list