[PATCH] [POWERPC] Emulate isel (Integer Select) instruction
Kim Phillips
kim.phillips at freescale.com
Thu Nov 22 08:48:13 EST 2007
On Wed, 21 Nov 2007 15:41:00 -0600
Scott Wood <scottwood at freescale.com> wrote:
> Paul Mackerras wrote:
> > Geert Uytterhoeven writes:
> >
> >> +#define WARN_EMULATE(type) \
> >> + do { \
> >> + static unsigned int count; \
> >> + if (count++ < 10) \
> >> + pr_warning("%s used emulated %s instruction\n", \
> >> + current->comm, type); \
> >
> > Thinking about this a bit more, if an instruction gets emulated 10
> > times then I don't care, since it's probably only cost me 10
> > microseconds or so. If it gets emulated a million times then I might
> > want to look at it. So in fact this approach doesn't give me the
> > information I need to know whether there is a real problem or not.
>
> Maybe print the first time, then when it's happened 10 times, then 100,
> then 1000, etc.
>
or just use printk_ratelimit().
Kim
More information about the Linuxppc-dev
mailing list