[PATCH 1/8] ibm_newemac: Fix possible lockup on close

Josh Boyer jwboyer at linux.vnet.ibm.com
Thu Nov 22 02:43:50 EST 2007


On Wed, 21 Nov 2007 16:41:23 +0100
Christoph Hellwig <hch at lst.de> wrote:

> On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote:
> > It's a bad idea to call flush_scheduled_work from within a
> > netdev->stop because the linkwatch will occasionally take the
> > rtnl lock from a workqueue context, and thus that can deadlock.
> > 
> > This reworks things a bit in that area to avoid the problem.
> 
> So from the name of the driver you want to keep the previous emac
> driver around.  Is there a good reason for that?

It's being kept around until arch/ppc dies.  Then things should get
renamed.

josh



More information about the Linuxppc-dev mailing list