[PATCH v7 3/9] add Freescale SerDes PHY support
galak at kernel.crashing.org
Wed Nov 21 14:31:59 EST 2007
On Oct 19, 2007, at 10:35 AM, Grant Likely wrote:
> On 10/19/07, Li Yang <leoli at freescale.com> wrote:
>> The SerDes(serializer/deserializer) PHY block is a new SoC block used
>> in Freescale chips to support multiple serial interfaces, such as PCI
>> Express, SGMII, SATA.
> This looks like board setup behaviour. Shouldn't setting this up be
> the responsibility firmware? And failing that, I think it should be
> done directly by the platform setup function (in other words; make it
> a helper function and call it at board setup time). Besides, you want
> to provide guarantees that the board is setup correctly before the
> device driver that uses it gets probed.
Upon further review of all this I don't think this belongs in the
kernel at all. This is one time setup and should be done in firmware.
More information about the Linuxppc-dev