dtc: Don't use env(1) in testsuite

David Gibson david at gibson.dropbear.id.au
Tue Nov 20 22:14:12 EST 2007


The run_tests.sh script currently invokes the testcase binaries via
env(1).  This behaviour is inherited from the libhugetlbfs testsuite
which uses this approach to easily set various configuration
environment variables in testcases.

We don't use that for dtc, and are unlikely to ever want to.
Therefore this patch removes that technique, which substantially
speeds up the testsuite.

Signed-off-by: David Gibson <david at gibson.dropbear.id.au>

Index: dtc/tests/run_tests.sh
===================================================================
--- dtc.orig/tests/run_tests.sh	2007-11-20 22:06:12.000000000 +1100
+++ dtc/tests/run_tests.sh	2007-11-20 22:06:22.000000000 +1100
@@ -2,8 +2,6 @@
 
 export QUIET_TEST=1
 
-ENV=/usr/bin/env
-
 tot_tests=0
 tot_pass=0
 tot_fail=0
@@ -13,7 +11,7 @@
 run_test () {
     tot_tests=$[tot_tests + 1]
     echo -n "$@:	"
-    if PATH=".:$PATH" $ENV "$@"; then
+    if "./$@"; then
 	tot_pass=$[tot_pass + 1]
     else
 	ret="$?"

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list