[PATCH v2] PMU: replace information ioctls and schedule for removal

Paul Mackerras paulus at samba.org
Tue Nov 20 14:33:27 EST 2007


Johannes Berg writes:

> This patch adds sysfs attributes to the PMU to allow getting
> the information on the PMU type and whether adb is present from
> there instead of via the ioctl. The ioctl is made optional and
> scheduled for removal.

I don't see any reason to ever remove the ioctls.  We're talking about
just 4 lines of code here.  Sure we can add the sysfs attributes -
even though that adds an order of magnitude more lines of code 
(thanks sysfs :) but I don't see any good reason to remove the
existing interface.

Paul.



More information about the Linuxppc-dev mailing list