[PATCH] powerpc: Fix 44x Machine Check handling

Kumar Gala galak at kernel.crashing.org
Sat Nov 17 08:54:03 EST 2007


On Nov 16, 2007, at 1:21 AM, Benjamin Herrenschmidt wrote:

> This removes the old CONFIG_440A which was a pain for multiplatform
> kernel and wasn't set properly by default and replaces it with a
> CPU feature. This makes Machine Check reporting work correctly on
> my Ebony (440GP) board.
>
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> ---
>
> Note: I'm only setting it for 440GX and EPx as the old code did,
> I haven't checked whether other new 440 chips such as SPe also
> need that bit set.
>
> arch/powerpc/kernel/cputable.c     |   10 +++++-----
> arch/powerpc/kernel/head_44x.S     |   11 ++++++-----
> arch/powerpc/kernel/traps.c        |   19 ++++++++-----------
> arch/powerpc/platforms/44x/Kconfig |    5 -----
> include/asm-powerpc/cputable.h     |    3 ++-
> include/asm-powerpc/reg_booke.h    |    2 +-
> 6 files changed, 22 insertions(+), 28 deletions(-)
>
[snip]

> Index: linux-work/include/asm-powerpc/cputable.h
> ===================================================================
> --- linux-work.orig/include/asm-powerpc/cputable.h	2007-11-16  
> 16:14:29.000000000 +1100
> +++ linux-work/include/asm-powerpc/cputable.h	2007-11-16  
> 16:19:35.000000000 +1100
> @@ -138,6 +138,7 @@ extern void do_feature_fixups(unsigned l
> #define CPU_FTR_FPU_UNAVAILABLE		ASM_CONST(0x0000000000800000)
> #define CPU_FTR_UNIFIED_ID_CACHE	ASM_CONST(0x0000000001000000)
> #define CPU_FTR_SPE			ASM_CONST(0x0000000002000000)
> +#define CPU_FTR_440A			ASM_CONST(0x0000000004000000)

Can we be more specific about what this feature really means.

How about something like CPU_FTR_ENH_MCHCK or something like that.

- k




More information about the Linuxppc-dev mailing list