[PATCH] powerpc: Add xmon function to dump 44x TLB

Segher Boessenkool segher at kernel.crashing.org
Sat Nov 17 03:09:31 EST 2007


>> +#ifdef CONFIG_44x
>> +static void dump_tlb_44x(void);
>> +#endif
>
> No need to #ifdef this...
>
>> +#ifdef CONFIG_44x
>> +static void dump_tlb_44x(void)
>> +{
>
> ...or this.

Erm actually, that last one would give you a compiler warning ("function
defined but not used"), unless you convert the point where it is used to
a plain "if" too -- probably not worth it until we have 32-bit 
multiplatform
support :-)


Segher




More information about the Linuxppc-dev mailing list