[PATCH 2/2] [POWERPC] consolidate struct pci_controller

Kumar Gala galak at kernel.crashing.org
Tue Nov 13 19:13:34 EST 2007


On Nov 13, 2007, at 2:06 AM, Olof Johansson wrote:

> On Tue, Nov 13, 2007 at 04:37:07PM +1100, Stephen Rothwell wrote:
>
>> This one clashes slightly with Benh's "Merge  
>> pci_process_bridge_OF_ranges()"
>> patch.
>
> Hi Stephen,
>
> For the small fields that use standard types, you should just be able
> to still define them for ppc32 and just not use them. Alternatively,
> if the 32-bit guys complain about wasted bytes of memory, bunch up the
> ppc64-only fields together for a single ifdef.

I doubt we'll complain too much for a struct that might have one or  
two instances at most.

But I think the ifdef's might be useful to people to see what code  
still needs to get merged between ppc32 & ppc64.

- k



More information about the Linuxppc-dev mailing list