[PATCH v4 04/13] [POWERPC] Add generic support for simple MPC5200 based boards

Marian Balakowicz m8 at semihalf.com
Tue Nov 13 09:22:16 EST 2007


Stephen Rothwell wrote:
> On Fri, 09 Nov 2007 18:12:02 +0100 Marian Balakowicz <m8 at semihalf.com> wrote:
>> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
>>
>> +static int __init mpc5200_simple_probe(void)
>> +{
>> +	unsigned long node = of_get_flat_dt_root();
> 
> You need to include asm/prom.h to use the flattened device tree accessors.

Right, but this one is already included in mpc52xx.h.

>> +	/* list of the supported boards */
>> +	const char *board[] = {	
>> +		"tqc,tqm5200",
>> +		"promess,motionpro",
>> +		"schindler,cm5200",
>> +		NULL
>> +	};
> 
> Make that static.

Board table is no longer needed after kernel is initialized, it would
be nice to declare it static and __initdata, but that would be quite
ugly as it's a table of pointers and each string would require
separate statement too. If we don't do it then what's the benefit of
making it static?

Cheers,
m.





More information about the Linuxppc-dev mailing list