[PATCH 2/6] ibm_newemac: Add ET1011c PHY support

Josh Boyer jwboyer at linux.vnet.ibm.com
Thu Nov 8 23:08:05 EST 2007


On Thu, 08 Nov 2007 19:42:24 +1100
Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:

> 
> > > +static struct mii_phy_def et1011c_phy_def = {
> > > +        .phy_id         = 0x0282f000,
> > > +        .phy_id_mask    = 0x0fffff00,
> > > +        .name           = "ET1011C Gigabit Ethernet",
> > > +        .ops            = &et1011c_phy_ops
> > > +};
> > > +
> > > +
> > > +
> > > +
> > > +
> > 
> > Nitpicking: Too many empty lines for my taste.
> 
> Agreed, I though I had removed them, looks like I didn't. Will fix that
> before submitting.

DENX is pretty good about having Signed-off-by lines in their tree...
maybe you should add the original authors as well if it's there.

josh



More information about the Linuxppc-dev mailing list