[PATCH v2 05/12] [POWERPC] Export mpc52xx_map_node() routine symbol

Stephen Rothwell sfr at canb.auug.org.au
Sun Nov 4 15:09:20 EST 2007


Hi Marian,

On Sun, 04 Nov 2007 00:52:40 +0100 Marian Balakowicz <m8 at semihalf.com> wrote:
>
> -static void __iomem *
> +void __iomem *
>  mpc52xx_map_node(struct device_node *ofn)
>  {
>  	const u32 *regaddr_p;
> @@ -48,6 +48,8 @@ mpc52xx_map_node(struct device_node *ofn)
>  	return ioremap((u32)regaddr64, (u32)size64);
>  }
>  
> +EXPORT_SYMBOL(mpc52xx_map_node);
> +

We generally don't leave a blank line between a function an its
EXPORT_SYMBOL(). Also, any reason not to use EXPORT_SYMBOL_GPL?

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20071104/aa8cceb4/attachment.pgp>


More information about the Linuxppc-dev mailing list