[PATCH v2]: Fix e500 v2 core reboot bug

Zang Roy-r61911 tie-fei.zang at freescale.com
Thu May 31 13:40:52 EST 2007


On Wed, 2007-05-30 at 21:49, Kumar Gala wrote:
> >>>>> I'm not terrible happy with blindly writing to rstcr.
> >>>>>
> >>>> I can understand you.
> >>>> But I jut want to make things simple and workable.
> >>>> Any idea?
> >>>
> >>> one idea would be for us to add a property on the soc node.
> >>> Something like has-rstcr or something similar in a guts node?
> >> I have seen your suggestion before to add a property in device
> tree.
> >> But I still think the current implementation is simple.
> >
> > While it simple you are depending on the fact that a given
> > implementation may or may not have something at the particular
> > offset.  Who knows if 8599 or some future part could put the 'cause
> > my part to smoke and self-destruct' at the same offset in the  
> > future :)
> >
> >> Anyway, I can try your suggestion.
> >
> > I'm thinking have a guts block and putting a property in it makes
> the
> > most sense.
> 
> After some discussion on IRC I think the following is the suggested  
> node we should add in.
> 
> guts at e00000 {
>         compatible = "fsl,mpc8548-guts";
>         reg = <e00000 1000>;
>         fsl,has-rstcr;
> };

Great!
Roy




More information about the Linuxppc-dev mailing list