[RFC/PATCH 4/5] powerpc: Make syscall restart code more common

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue May 29 21:41:25 EST 2007


On Tue, 2007-05-29 at 13:32 +0200, Christoph Hellwig wrote:
> On Tue, May 29, 2007 at 04:45:23PM +1000, Benjamin Herrenschmidt
> wrote:
> > +static inline void check_syscall_restart(struct pt_regs *regs,
> > +                                      struct k_sigaction *ka,
> > +                                      int has_handler)
> > +{
> 
> I don't think this should be inlined.  Just create a new signal.c
> file,
> which can grow a lot more common signal code later on aswell.

I've been thinking about doing that too. In fact, some of the
ptrace-common.h stuff should probably be turned back into ptrace.c too
for the same reason. I'm still toying with that part of the designm but
yeah, I think that's something to do.

Ben.





More information about the Linuxppc-dev mailing list