[patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver

Benjamin Herrenschmidt benh at kernel.crashing.org
Sat May 26 08:35:39 EST 2007


On Fri, 2007-05-25 at 10:36 +0200, Geert.Uytterhoeven at sonycom.com wrote:
> -#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE)
> +#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) || \
> +    defined(CONFIG_PS3_FLASH_MODULE) ||
> defined(CONFIG_PS3_FLASH_MODULE)

As I said multiple times, imho, #ifdef CONFIG_xxx_MODULE in the kernel
is always a bug.

You should always be able to build the module out of tree afteward and
use it on a kernel that didn't have the CONFIG_xxx_MODULE set imho.

Ben.





More information about the Linuxppc-dev mailing list