[PATCH] [POWERPC] remove build warnings in windfarm_core
Geert Uytterhoeven
Geert.Uytterhoeven at sonycom.com
Fri May 18 21:20:29 EST 2007
On Thu, 17 May 2007, Stephen Rothwell wrote:
> diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c
> index 192b26e..11ced17 100644
> --- a/drivers/macintosh/windfarm_core.c
> +++ b/drivers/macintosh/windfarm_core.c
> @@ -216,7 +216,10 @@ int wf_register_control(struct wf_control *new_ct)
> new_ct->attr.attr.mode = 0644;
> new_ct->attr.show = wf_show_control;
> new_ct->attr.store = wf_store_control;
> - device_create_file(&wf_platform_device.dev, &new_ct->attr);
> + if (device_create_file(&wf_platform_device.dev, &new_ct->attr))
> + printk(KERN_WARNING "windfarm: device_create_file failed"
> + " for %s\n", new_ct->name);
> + /* the subsystem still does useful work without the file */
Confusing indentation: the comment is not part of the branch
> @@ -326,7 +329,10 @@ int wf_register_sensor(struct wf_sensor *new_sr)
> new_sr->attr.attr.mode = 0444;
> new_sr->attr.show = wf_show_sensor;
> new_sr->attr.store = NULL;
> - device_create_file(&wf_platform_device.dev, &new_sr->attr);
> + if (device_create_file(&wf_platform_device.dev, &new_sr->attr))
> + printk(KERN_WARNING "windfarm: device_create_file failed"
> + " for %s\n", new_sr->name);
> + /* the subsystem still does useful work without the file */
Ditto.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven at sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium
More information about the Linuxppc-dev
mailing list