[PATCH 5/5] PCI fixes for the MPC8641 Rev 2.0 silicon and Rev1.02 hardware

[Jin Zhengxiong-R64188]

> -----Original Message-----
> From: linuxppc-dev-bounces+jinzhengxiong=gmail.com at ozlabs.org 
> [mailto:linuxppc-dev-bounces+jinzhengxiong=gmail.com at ozlabs.or
> g] On Behalf Of Wade Farnsworth
> Sent: Thursday, May 17, 2007 2:07 AM
> To: Loeliger Jon-LOELIGER
> Cc: linuxppc-dev
> Subject: Re: [PATCH 5/5] PCI fixes for the MPC8641 Rev 2.0 
> silicon and Rev1.02 hardware
> 
> On Wed, 2007-05-16 at 11:44 -0500, Jon Loeliger wrote:
> > On Tue, 2007-05-15 at 11:50, Wade Farnsworth wrote:
> > > +static void __devinit early_mpc86xx_pcie(struct pci_dev *dev) {
> > > +	   dev->class = PCI_CLASS_BRIDGE_PCI << 8 | 0x1; }
> > 
> > What'd we decide on that 0x1 in there?
> > 
> > Thanks,
> > jdl
> > 
> > 
> 
> I originally thought that it the 0x1 was necessary, but it 
> was pointed out to me that it should not be.
> 
> If I remove the 0x1 I get some I/O resource allocation 
> failures on the P2P bridge and its child devices.  I'm 
> currently investigating what the cause of this is.

> --Wade
> 

As you changed the class of the bridge, dev->transparent will be set
again in the later  code, if you remove the 0x01 here, the
dev->transparent will be set to 0 later. So if you changed the class
like this, you do not need to set  dev->transparent = 1 in your patch.

Jason 




> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>