Fix bug adding properties with flatdevtree.c's ft_set_prop()

Mark A. Greer mgreer at mvista.com
Wed May 16 04:11:40 EST 2007


On Tue, May 15, 2007 at 10:26:48AM +1000, David Gibson wrote:
> On Mon, May 14, 2007 at 11:28:16AM -0500, Scott Wood wrote:
> > On Mon, May 14, 2007 at 01:13:57PM +1000, David Gibson wrote:
> > > This patch corrects ft_set_prop() so that it adds new properties
> > > before the first subnode, instead of before the END_NODE tag.
> > 
> > Is there any reason not to just insert at the beginning of the node?
> 
> Only that we have to search through the node first to see if the
> property already exists, so we've already reached the end by the time
> we know we need to insert.

David, Jon,

Does dtc guarantee that there aren't any properties after a subnode?

Mark



More information about the Linuxppc-dev mailing list