Fix bug adding properties with flatdevtree.c's ft_set_prop()

Mark A. Greer mgreer at mvista.com
Wed May 16 04:08:05 EST 2007


On Mon, May 14, 2007 at 01:13:57PM +1000, David Gibson wrote:
> ft_set_prop() from flatdevtree.c in the zImage wrapper will either
> replace an existing property in the flat device tree, or add a new
> property definiion if the given property isn't present.
> 
> However, when adding properties, it adds the property definition
> immediately before the node's END_NODE tag, potentially after any
> subnode definitions for the node.  This confuses the kernel flat tree
> parser in prom.c which assumes that all property definitions for a
> node come before all subnode definitions.

Oops. :)

> This patch corrects ft_set_prop() so that it adds new properties
> before the first subnode, instead of before the END_NODE tag.
> 
> Signed-off-by: David Gibson <david at gibson.dropbear.id.au>

Acked-by: Mark A. Greer <mgreer at mvista.com>



More information about the Linuxppc-dev mailing list