[PATCH 2/2] powerpc: Fix IO space on PCI busses created from of_platform

Arnd Bergmann arnd.bergmann at de.ibm.com
Tue May 15 23:24:39 EST 2007


On Tuesday 15 May 2007, Benjamin Herrenschmidt wrote:
> +       /* Setup IO space. We use the non-dynamic version of that code here,
> +        * which doesn't quite support unplugging. Next kernel release will
> +        * have a better fix for this.
> +        * Note also that we don't do ISA, this will also be fixed with a
> +        * more massive rework.
>          */
> -       pci_setup_phb_io_dynamic(phb, 0);
> +       pci_setup_phb_io(phb, 0);
>  

I think this still needs some logic to make sure we have at least one
primary PHB in the system. On a board that has all phbs probed by
of_platform code, we never set the pci_io_base variable.

The easiest solution might be to statically initialize pci_io_base
to PHBS_IO_BASE. If it is different from that, we are already broken
because we would get _negative_ I/O port numbers for PHBs below
pci_io_base.

	Arnd <><



More information about the Linuxppc-dev mailing list