[PATCH] [POWERPC] remove build warnings in windfarm_core

Paul Mackerras paulus at samba.org
Tue May 15 16:19:53 EST 2007


Stephen Rothwell writes:

> -	device_create_file(&wf_platform_device.dev, &new_ct->attr);
> +	ret = device_create_file(&wf_platform_device.dev, &new_ct->attr);
> +	if (ret) {
> +		list_del(&new_ct->link);
> +		printk(KERN_WARNING "windfarm: device_creat_file failed"
> +			"for %s\n", new_ct->name);
> +		goto out_unlock;

This shows up why I hate the must_check stuff.  The sysfs files are
not essential for the operation of the windfarm subsystem.  If the
sysfs registration fails for any reason, we now have a completely
non-functional windfarm subsystem instead of a mostly-working one. :(

Paul.



More information about the Linuxppc-dev mailing list