Small fixes for the Ebony device tree
David Gibson
david at gibson.dropbear.id.au
Tue May 15 15:47:58 EST 2007
On Tue, May 15, 2007 at 07:11:07AM +0200, Segher Boessenkool wrote:
> Just a few more things...
>
> > plb {
> > - device_type = "ibm,plb";
> > compatible = "ibm,plb-440gp", "ibm,plb4";
>
> You match on "ibm,plb" though. Well you got one
> in three right ;-)
Indeed. And I'm still not sure how it's recognizing the plb devices
right now...
> > + SDRAM0: memory-controller {
> > compatible = "ibm,sdram-440gp", "ibm,sdram";
>
> "ibm,sdram" is way too generic to ever be usefully
> used for device matching.
Yeah, I guess this should be ibm,sdram-44x or ibm,sdram-4xx. Better
go look up if any 40x chips use a similar sdram controller.
> > + SRAM0: sram {
> > + compatible = "ibm,sram440gp";
>
> You spell this one without a dash, all others with one.
Ah, yes, oops...
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
More information about the Linuxppc-dev
mailing list