[PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

Andrew Morton akpm at linux-foundation.org
Tue May 15 07:21:25 EST 2007


On Wed, 09 May 2007 02:31:25 +0400
Vitaly Bordug <vitb at kernel.crashing.org> wrote:

> +/* 
> + * Some internal interrupt registers use an 8-bit mask for the interrupt
> + * level instead of a number.
> + */
> +static inline uint mk_int_int_mask(uint mask) {
> +	return (1 << (7 - (mask/2)));
> +}

grumble.  "uint" isn't a favoured "type".  Please prefer to
use "unsigned int" if that's what is meant.  Or maybe u32,
if that's more appropriate - and it probably is, as we're
dealing with device registers here.



More information about the Linuxppc-dev mailing list