[PATCH 11/13] powerpc: Add DTS file for the Motorola PrPMC2800 platform

Jerry Van Baren gvb.linuxppc.dev at gmail.com
Sun May 13 10:00:17 EST 2007


Segher Boessenkool wrote:
>>> +			partition-names = "FW Image A\0FW Config Data\0Kernel 
>>> Image\0Filesystem\0FW Image B";
>> dtc now supports the syntax:
>> 	partition-names = "FW Image A", "FW Config Data", ...
>> for multi-string properties to make this sort of thing less ugly.
> 
> Nice!  Can you also concatenate different property
> encodings that way?  Like,
> 
> 	slot-names = <5>, "Slot A", "Slot C";
> 
> or something like that?
> 
> Segher

Hi Segher,

That doesn't make sense to me.  It would be a bugger to understand the 
value of "slot-names" since <5> is a number and the rest are strings. 
How do you know it is a number?  How do you know how big it is?

If <5> is a single byte, it will look like "\05Slot A\0Slot C" (ASCII 
<ENQ> as the first character of two concatenated strings).  If it is a 4 
or 8 byte integer, it will have preceding "nulls" (big endian) which 
would be even worse.

It seems to me that it would be much better as
   slot-names = "5", "Slot A", "Slot C";
and do an atoi() conversion if you detect it is or expect it to be numeric.

gvb



More information about the Linuxppc-dev mailing list