[PATCH 05/13] Document the fsl, magic-packet property in gianfar nodes.

Segher Boessenkool segher at kernel.crashing.org
Thu May 10 16:57:52 EST 2007


>>>>>> As I previously wrote internally, it's only needed because some
>>>>>> versions of the device have it and some don't; what it really 
>>>>>> means
>>>>>> is that certain bits in certain registers are valid.
>>
>> So have the driver detect this based on "compatible"
>> or "model".
>
> Thus requiring the driver to maintain a list of models/compatibles for
> every possible combination of features,

Most likely a very short list.  But you know best
of course.

> rather than letting the device
> tree specify them individually.  What would be the advantage in that?

It's a tradeoff -- describing every single bit of
the hardware in the device tree is a way bigger
maintenance burden, be careful not to go overboard
with it.


Segher




More information about the Linuxppc-dev mailing list