[PATCH 1/4] powerpc: EEH: log error only after driver notification.
Olof Johansson
olof at lixom.net
Wed May 9 14:51:15 EST 2007
Hi,
On Tue, May 08, 2007 at 06:33:29PM -0500, Linas Vepstas wrote:
> Index: linux-2.6.21-rc7-mm2/arch/powerpc/platforms/pseries/eeh_driver.c
> ===================================================================
> --- linux-2.6.21-rc7-mm2.orig/arch/powerpc/platforms/pseries/eeh_driver.c 2007-05-08 17:55:43.000000000 -0500
> +++ linux-2.6.21-rc7-mm2/arch/powerpc/platforms/pseries/eeh_driver.c 2007-05-08 17:56:42.000000000 -0500
> @@ -361,7 +361,6 @@ struct pci_dn * handle_eeh_events (struc
> goto hard_fail;
> }
>
> - eeh_slot_error_detail(frozen_pdn, 1 /* Temporary Error */);
> printk(KERN_WARNING
> "EEH: This PCI device has failed %d times since last reboot: "
> "location=%s driver=%s pci addr=%s\n",
> @@ -375,6 +374,11 @@ struct pci_dn * handle_eeh_events (struc
> */
> pci_walk_bus(frozen_bus, eeh_report_error, &result);
>
> + /* Since rtas may enable MMIO when posting the error log,
> + * don't post the error log until after all dev drivers
> + * have been informed. */
> + eeh_slot_error_detail(frozen_pdn, 1 /* Temporary Error */);
I know you only moved it, but if you have to document what '1' means,
you really should add a symbolic define/enum instead. Not saying it should
stop this from going in, but it could be a good separate improvement.
(Also, the comment style: */ should be on it's own line.)
-Olof
More information about the Linuxppc-dev
mailing list