[PATCH 3/3] [POWERPC] dts: kill hardcoded phandles

Loeliger Jon-LOELIGER jdl at freescale.com
Wed May 9 00:29:20 EST 2007


> > -       interrupt-controller at f8200000 {
> > -               linux,phandle = <f8200000>;
> > +		pci_pic:interrupt-controller at f8200000 {
> 
> I'd like to establish a convention of putting a space after the : and
> using capitals for labels unless there's a strong reason not to in a
> particular case.  It makes them easier to visually distinguish next to
> the node name.

Colon-space is easy and I'll buy it.
I'm not big on uppercase shouting, though.

Perhaps something more like case or goto labels:?

    pci_pic:
        interrupt-contoller at f8200000 {

if needed?

jdl



More information about the Linuxppc-dev mailing list