[PATCH v4 7/7] Holly bootwrapper

[Josh Boyer]

On Tue, May 08, 2007 at 10:16:04AM +1000, David Gibson wrote:
> On Mon, May 07, 2007 at 04:32:10PM -0500, Josh Boyer wrote:
> > @@ -129,6 +129,7 @@ image-$(CONFIG_PPC_CELLEB)		+= zImage.ps
> >  image-$(CONFIG_PPC_CHRP)		+= zImage.chrp
> >  image-$(CONFIG_PPC_EFIKA)		+= zImage.chrp
> >  image-$(CONFIG_PPC_PMAC)		+= zImage.pmac
> > +image-$(CONFIG_PPC_HOLLY)		+= zImage.holly-elf
> 
> Since ELF appears to be the standard image type, I'd suggest just
> calling it zImage.holly.

Fine by me.  Though PIBS can take either elf or treeboot images.  Was just
being explicit.

> 
> >  image-$(CONFIG_DEFAULT_UIMAGE)		+= uImage
> >  
> >  ifneq ($(CONFIG_DEVICE_TREE),"")
> > @@ -164,6 +165,12 @@ $(obj)/zImage.ps3: vmlinux
> >  $(obj)/zImage.initrd.ps3: vmlinux
> >  	@echo "  WARNING zImage.initrd.ps3 not supported (yet)"
> >  
> > +$(obj)/zImage.holly-elf: vmlinux $(wrapperbits)
> > +	$(call if_changed,wrap,holly,$(obj)/dts/holly.dts,,)
> > +
> > +$(obj)/zImage.initrd.holly-elf: vmlinux $(wrapperbits) $(obj)/ramdisk.image.gz
> > +	$(call if_changed,wrap,holly,$(obj)/dts/holly.dts,,$(obj)/ramdisk.image.gz)
> 
> Um.. won't this need corresponding changes to the wrapper script.  I
> don't see them..

No...  -i to the wrapper script handles an initrd.  And quiet_cmd_wrap
optionally takes a 5th argument for it.  What other changes are you thinking?

> > +void platform_init(unsigned long r3, unsigned long r4, unsigned long r5)
> > +{
> > +	u32 heapsize = 0x8000000 - (u32)_end; /* 128M */
> 
> Urg... careful here.  Can you guarantee that 128M are present at this
> point?  I know I do this in Ebony; I need to fix that..

I believe so.  I can make it smaller in a future patch that will add some
other things to the bootwrapper.

josh