[PATCH 05/13] Document the fsl, magic-packet property in gianfar nodes.

[Kumar Gala]

On May 7, 2007, at 4:51 PM, Andy Fleming wrote:

>
> On May 7, 2007, at 16:29, Scott Wood wrote:
>
>> Andy Fleming wrote:
>>> On May 7, 2007, at 13:29, Scott Wood wrote:
>>>> +   Optional properties:
>>>> +    - fsl,magic-packet : Indicates that this device supports wake
>>>> +      on Magic Packet.
>>>> +
>>> Isn't this a fairly generic option?  Does it need the "fsl"
>>> qualifier?
>>
>> As I previously wrote internally, it's only needed because some
>> versions of the device have it and some don't; what it really means
>> is that certain bits in certain registers are valid.  Making it
>> generic would imply that all hardware that can do magic packet
>> should have it, which isn't true.
>
>
> Yeah, I just read that.  You should either make that more explicit in
> the documentation, or make it generic.  It's fine if there are
> drivers/devices that don't need to be told or tell anyone that they
> recognize magic packets for them to work.  The lack of the property
> in other controllers won't break anything.
>
> But I'm fine if you just document that the bit indicates,
> specifically, the presence of magic-packet bits in certain registers
> on the eTSEC.

I'd ask is it really freescale specific?  In that I'd assume its  
support for the standard wake-on-lan packet.

- k