[PATCH] Remove CPU_FTR_NEED_COHERENT for 7448.

Loeliger Jon-LOELIGER jdl at freescale.com
Tue May 8 03:31:24 EST 2007


> Sorry I don't remember the actual patch, must have missed it... I
> suppose we could have generic code in early_init_devtree set 
> the default
> for this based on cpu_possible_map() containing more than one bit and
> have platforms using one of those broken bridges force the bit in from
> their probe routine.
> 
> Ben.

Hi Ben,

Yeah, I had no actual intention of retrofitting
This into all the existing boards.  I was more
Wanting to leave them alone and simply un-set the
Bit on the one board where I wanted it done better.

My proposed solution in the _probe() routine was:

        static int __init mpc86xx_hpcn_probe(void)
        {
        	unsigned long root = of_get_flat_dt_root();
        
        	if (of_flat_dt_is_compatible(root, "mpc86xx")) {
        		/* get number_of_cpus() from somewhere */
        		if (number_of_cpus() == 1) {
        			cur_cpu_spec->cpu_features &=
~CPU_FTR_NEED_COHERENT;
        		}
        		return 1;	/* Looks good */
        	}
        
        	return 0;
        }

Or perhaps:

        static int __init mpc86xx_hpcn_probe(void)
        {
        	unsigned long root = of_get_flat_dt_root();
        
        	if (of_flat_dt_is_compatible(root, "mpc86xx")) {
	  #ifndef CONFIG_SMP
        		cur_cpu_spec->cpu_features &=
~CPU_FTR_NEED_COHERENT;
	  #endif
        		return 1;	/* Looks good */
        	}
        
        	return 0;
        }

Specifically, which notion of multi-CPU-ness do
We want to honor here?

Thanks,
Jdl



More information about the Linuxppc-dev mailing list