[PATCH 3/13] powerpc: Add bootwrapper support for Marvell/mv64x60 hostbridge

[Paul Mackerras]

Mark A. Greer writes:

> Actually, none of the config code should be needed by the bootwrapper
> itself because the bootwrapper mpsc and i2c drivers use PIO (so accessing
> memory isn't an issue).  The "get info" type routines are still needed.

Talking of i2c, why does the bootwrapper need an i2c driver at all?
You don't tell me in the patch description for your patch 5/13...

> Its pretty much 1:1.  Whatever is in the bootwrapper (including
> #define's) isn't needed in the kernel.

OK, good.

> I expect that the setup will be done the same for all of the boards
> that need it.  Not all of the boards will need it, though.  It depends
> on their firmware.  The config code is filling the gap between what the
> firmware should have done and what the kernel drivers require (i.e.,
> allowing the ctlrs to access system memory and pci mem/io space).

Is it possible that different kernels will want things set up
differently?  Or is there really only one sensible setup?

> Paul, I'm a little perplexed by you wanting this code pushed back into
> the kernel.  A while back there was a definite desire to push stuff like
> this out of the kernel (mainly by Ben).  I tend to agree with Ben on
> this.  Either way, it would good to have everyone pushing in the same
> direction. :)

One of these days you guys will write me nice informative patch
descriptions that explain the rationale and design decisions behind
the changes you're proposing, without me nagging. :) I'm not so much
pushing back as trying to get you to tell me why the code is here and
not somewhere else, and what the obvious alternatives might be and why
we aren't doing them.  Or better still, put that information into a
new set of patch descriptions for me...

BTW, the descriptions on your string of 13 were completely empty for
many of them, and for the remainder they just said what had been
changed.  Please be more informative.  Yes, it does require thinking
about things from the point of view of someone who doesn't have all
the context in their head, as you do, which can take a bit of mental
effort.  But in 2 or 3 years time it might be you that doesn't have
the context in mind any more and will really appreciate a more verbose
description. :)

Paul.