[PATCH 5/6] Support for the Ebony 440GP reference board in arch/powerpc

[Segher Boessenkool]

>>> How?   CPP doesn't apply inside the strings.
>>
>> So put it outside the strings:
>>
>> +     asm volatile (
>> +             "mfspr  %0," #SPRN_DBCR0 "\n\t"
>> +             "oris   %0,%0," #DBCR0_RST_SYSTEM "@h\n\t"
>> +             "mtspr  " #SPRN_DBCR0 ",%0"
>> +             : "=&r"(tmp));
>
> Um, I think stringify(SPRN_DBCR0) is needed there, not just a bare #.

Yes of course.  Someone is paying attention ;-) (*)

> At which point it's not entirely clear to be that just using the "i"
> constraint isn't the simplest option after all.

Sure.  Or even hardcoding the values (with comments),
which would show why a bare "oris" is correct at all.


Segher




(*) ... just not me