[PATCH 1/4] Add support for 750CL Holly board

[Josh Boyer]

On Sat, 2007-05-05 at 09:39 -0500, Olof Johansson wrote:
> On Fri, May 04, 2007 at 09:44:30PM +0200, Arnd Bergmann wrote:
> 
> > > --- linux-2.6.orig/include/asm-powerpc/tsi108.h
> > > +++ linux-2.6/include/asm-powerpc/tsi108.h
> > > @@ -68,7 +68,11 @@
> > >  #define TSI108_PB_ERRCS_ES		(1 << 1)
> > >  #define TSI108_PB_ISR_PBS_RD_ERR	(1 << 8)
> > >  
> > > +#ifdef CONFIG_HOLLY
> > > +#define TSI108_PCI_CFG_BASE_PHYS	(0x7c000000)
> > > +#else
> > >  #define TSI108_PCI_CFG_BASE_PHYS	(0xfb000000)
> > > +#endif
> > >  #define TSI108_PCI_CFG_SIZE		(0x01000000)
> > >  /* Global variables */
> > > 
> > 
> > Same here.
> 
> It would be very easy to take tsi108_setup_pci take the config base as
> a function paramter and pass it in from the board setup code, and store
> it in a static variable to be used for the tsi108_clear_pci_cfg_error
> function.
> 
> That'd easily make the code multiplatform friendly without having to
> add it to the device tree. Very few other platforms have the config base
> address in there, if any. It shouldn't be a requirement that Holly has it.

Yeah, after thinking about it, that's what I plan on doing actually.

josh